MLE-26420 Improved error handling for incremental writes

[rjrudin]

No description provided.

[github-actions]

Copyright Validation Results
Total: 2 | Passed: 2 | Failed: 0 | Skipped: 0 | at: 2025-12-31 16:33:23 UTC | commit: 88c9beb

✅ Valid Files

• marklogic-client-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteFilter.java
• marklogic-client-api/src/test/java/com/marklogic/client/datamovement/filter/IncrementalWriteTest.java

✅ All files have valid copyright headers!

[Copilot]

Pull request overview

This PR improves error handling in the incremental write functionality by ensuring that failures during JSON canonicalization are properly logged while still allowing the write operation to proceed or fail based on the actual format of the content. The key change is the addition of comprehensive test coverage for invalid JSON scenarios and improved documentation around error handling behavior.

Key Changes:

• Added test coverage for invalid JSON handling with and without explicit format specification
• Enhanced error handling documentation in IncrementalWriteFilter
• Refactored test setup to reduce code duplication

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
IncrementalWriteTest.java	Added tests for invalid JSON scenarios, refactored test setup with shared state variables, and removed unused WriteBatcherTemplate utility class
IncrementalWriteFilter.java	Updated comment to clarify error handling strategy when JSON canonicalization fails

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The docs list is now shared across all test methods as instance state. This can lead to test pollution if not properly cleared between tests. Consider initializing it in the @BeforeEach method or making it local to each test method to ensure test isolation.

Suggested change

	List<DocumentWriteOperation> docs = new ArrayList<>();
	IncrementalWriteFilter filter;
	@BeforeEach
	void setup() {
	List<DocumentWriteOperation> docs;
	IncrementalWriteFilter filter;
	@BeforeEach
	void setup() {
	// Ensure docs is reinitialized for each test to avoid shared state between tests.
	docs = new ArrayList<>();

[Copilot]

Corrected spelling of 'aaa' to a more descriptive test file name.

[Copilot]

Corrected spelling of 'aaa' to a more descriptive test file name.