Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Dec 31, 2025

No description provided.

@rjrudin rjrudin requested a review from BillFarber as a code owner December 31, 2025 21:04
Copilot AI review requested due to automatic review settings December 31, 2025 21:04
@rjrudin rjrudin requested a review from stevebio as a code owner December 31, 2025 21:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds timestamp tracking to the incremental write functionality by storing a timestamp alongside the hash value in document metadata. The changes ensure that each document written through the incremental write filter captures both when it was written (timestamp) and its content signature (hash).

Key changes:

  • Renamed fieldName to hashKeyName throughout the codebase to better reflect that it's a metadata key, not a field name
  • Added timestampKeyName parameter with default value "incrementalWriteTimestamp" to track when documents are written
  • Updated the addHashToMetadata method to accept and store both hash and timestamp values

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
IncrementalWriteFilter.java Core changes: renamed field parameter, added timestamp key parameter, and updated metadata storage to include timestamp
IncrementalWriteOpticFilter.java Updated constructor and field reference to use new hashKeyName parameter
IncrementalWriteEvalFilter.java Updated constructor and JavaScript eval script to use hashKeyName instead of fieldName
IncrementalWriteFilterTest.java Added test assertions to verify timestamp is correctly added to metadata
IncrementalWriteTest.java Updated method calls to use hashKeyName and added timestamp validation in verification method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Copyright Validation Results
Total: 5 | Passed: 5 | Failed: 0 | Skipped: 0 | at: 2025-12-31 21:04:14 UTC | commit: 143d5f1

✅ Valid Files

  • marklogic-client-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteEvalFilter.java
  • marklogic-client-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteFilter.java
  • marklogic-client-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteOpticFilter.java
  • marklogic-client-api/src/test/java/com/marklogic/client/datamovement/filter/IncrementalWriteFilterTest.java
  • marklogic-client-api/src/test/java/com/marklogic/client/datamovement/filter/IncrementalWriteTest.java

✅ All files have valid copyright headers!

@rjrudin rjrudin merged commit d7f4b7a into develop Dec 31, 2025
3 checks passed
@rjrudin rjrudin deleted the feature/26428-incremental-timestamp branch December 31, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants