MLE-26340 expose vec.precision and vec.trunc in Node client. #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
stevebio
force-pushed
the
feature/26338-add-vec-precision-trunc
branch
from
513e69f to
09aac63
Compare
stevebio
changed the title
stevebio
force-pushed
the
feature/26338-add-vec-precision-trunc
branch
6 times, most recently
from
973a87c to
5e05814
Compare
There was a problem hiding this comment.
Pull request overview
This PR exposes two new vector functions (vec.precision and vec.trunc) in the Node.js client library and updates existing vector function tests with improved assertions and comments.
Key Changes:
- Added
vec.precisionandvec.truncfunction definitions to the plan builder - Updated test suite with clearer assertions and explanatory comments
- Modernized test code by replacing
pwithopfor plan builder references - Updated copyright year to 2026 across affected files
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| lib/plan-builder-generated.js | Added precision and trunc function definitions for the vec namespace with JSDoc documentation |
| lib/plan-builder-base.js | Modified VecVector type handling in castArg to return the arg directly instead of arg._args |
| test-basic/optic-vector.js | Refactored tests with improved assertions, added skipped tests for new vec functions, and updated variable naming from p to op |
| test-basic/plan-builder-generated.js | Updated vec.base64Decode test with corrected test data and assertion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stevebio
force-pushed
the
feature/26338-add-vec-precision-trunc
branch
from
5e05814 to
72d2c79
Compare
Update high vulnerability Add comment about VecVector Update copyright
stevebio
force-pushed
the
feature/26338-add-vec-precision-trunc
branch
from
72d2c79 to
3024522
Compare
Collaborator
Author
|
Ling added vec.precision and vec.trunc and now op calls work. |
rjrudin
approved these changes
Jan 6, 2026
|
|
||
| const marklogic = require('../'); | ||
| const p = marklogic.planBuilder; | ||
| const op = marklogic.planBuilder; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.