Skip to content

Fixed failing tests [no_release] #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lachiebol wants to merge 1 commit into from
Closed

Fixed failing tests [no_release] #32

lachiebol wants to merge 1 commit into from

Conversation

@lachiebol
Copy link
Contributor

@lachiebol lachiebol commented Dec 18, 2025 •
edited
Loading

Description

UI tests were breaking from AI assistant core changes

Issue No

Steps to Replicate the Issue

Checklist

  • [✖] Tested locally or on demo2/demo3?
  • [NA] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [NA] Version bumped?
  • [NA] I have understood, reviewed, and tested all AI outputs before use
  • [NA] All AI instructions respect security, IP, and privacy rules

@lachiebol lachiebol requested a review from a team December 18, 2025 22:48
@lachiebol lachiebol added the Needs Review For pull requests that need a code review. label Dec 18, 2025
@AltamashShaikh
Copy link
Contributor

AltamashShaikh commented Dec 19, 2025

@lachiebol Closing this as we already have fixed this in - #31

@AltamashShaikh AltamashShaikh deleted the fix_tests_20251209 branch December 19, 2025 03:54
lachiebol
lachiebol commented Dec 21, 2025
View reviewed changes
Copy link
Contributor Author

@lachiebol lachiebol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Needs Review For pull requests that need a code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lachiebol @AltamashShaikh