Fix invalid construction of greedy sampler in LlamaLanguageModel #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the greedy sampling mode implementation within LlamaLanguageModel. The greedy sampler was missing the required llama_sampler_init_greedy() call in its sampler chain, which is now properly added. The test suite is also refactored to use a simpler model initialization pattern.
Key changes:
- Added missing
llama_sampler_init_greedy()call to complete the greedy sampling chain - Simplified test model initialization from computed property to direct constant
- Removed redundant
customTemperature()test
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/AnyLanguageModel/Models/LlamaLanguageModel.swift | Adds the missing llama_sampler_init_greedy() call to properly initialize greedy sampling mode |
| Tests/AnyLanguageModelTests/LlamaLanguageModelTests.swift | Simplifies model initialization and removes redundant test case |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #51
This fixes the crash observed when running unit tests.