Pass entire transcript to Foundation Models session #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
force-pushed
the
mattt/system-transcript
branch
from
8f91c7e to
79e7d3a
Compare
There was a problem hiding this comment.
Pull request overview
This PR enhances the SystemLanguageModel integration with Apple's FoundationModels framework by passing entire conversation transcripts instead of just instructions. This enables multi-turn conversations and richer context to be preserved when interacting with Apple Intelligence models.
Key changes:
- Changed
ToolDefinition.parametersaccess level fromprivatetointernalto support conversion to FoundationModels format - Updated
SystemLanguageModelto pass full transcripts to FoundationModels sessions inrespond()andstreamResponse()methods - Added comprehensive conversion logic to transform AnyLanguageModel transcript entries (instructions, prompts, responses, tool calls, tool outputs) to FoundationModels format
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| Sources/AnyLanguageModel/Transcript.swift | Made ToolDefinition.parameters internal to allow access for FoundationModels conversion |
| Sources/AnyLanguageModel/Models/SystemLanguageModel.swift | Replaced instructions-only parameter with full transcript conversion in session creation; added conversion extensions for Transcript, Segment arrays, and ToolDefinition arrays |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
This is now in 0.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #52