Refactor message history construction from Transcription in MLXLanguageModel
#66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion in MLXLanguageModel
mattt
approved these changes
Dec 17, 2025
Owner
|
Thank you, @noorbhatia! I just made a few changes to clean up those helper methods. Merging this now. |
Owner
|
This is now in 0.5.1 |
XMLHexagram
added a commit
to XMLHexagram/AnyLanguageModel
that referenced
this pull request
Dec 22, 2025
Fix compilation error where streamResponse was calling non-existent helper functions (extractInstructionSegments, convertSegmentsToMLXMessage, etc.) that were removed in the refactoring PR mattt#66. Now uses convertTranscriptToMLXChat, consistent with the respond method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #52 for
MLXLanguageModel