Skip to content

Conversation

@joshlarson
Copy link
Contributor

Scope

Asana Ticket: Update how parking issue alerts are handled on stop page amenity cards

Implementation

  • Adds a new function called StopAmenity.closed_by_alerts?/2 that's analogous to StopAmenity.affected_by_alerts?/2, but uses the amenity type and the alert type to determine if the amenity is fully closed, versus just affected.
  • Shows a different badge on the stop amenity card for closed_by_alerts? versus affected_by_alerts?.

Screenshots

Screenshot 2026-01-22 at 2 05 11 PM

How to test

Go to the Lynn stop page and scroll down to the amenity cards. Rejoice at the presence of a Temporary issue badge.

Notes

Follow-up to:

@joshlarson joshlarson requested a review from a team as a code owner January 22, 2026 19:09
@joshlarson joshlarson requested a review from thecristen January 22, 2026 19:09
@joshlarson joshlarson enabled auto-merge (squash) January 22, 2026 19:17
@joshlarson joshlarson merged commit bb62e5e into main Jan 22, 2026
26 checks passed
@joshlarson joshlarson deleted the jdl/fix/parking-issue-amenity-card-badge branch January 22, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants