fix: Show Temporary issue for parking issue alerts on parking amenity cards
#2902
+66
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: Update how parking issue alerts are handled on stop page amenity cards
Implementation
StopAmenity.closed_by_alerts?/2that's analogous toStopAmenity.affected_by_alerts?/2, but uses the amenity type and the alert type to determine if the amenity is fully closed, versus just affected.closed_by_alerts?versusaffected_by_alerts?.Screenshots
How to test
Go to the Lynn stop page and scroll down to the amenity cards. Rejoice at the presence of a
Temporary issuebadge.Notes
Follow-up to:
Temporarily closedbadge from parking amenity card #2901