[MOO-1942]: IntroScreen with conditional visibility not rendering (Mx 11) #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| } else { | ||
| setVisible(true); | ||
| InteractionManager.runAfterInteractions(() => setVisible(true)); |
Collaborator
There was a problem hiding this comment.
We'll need to update this after upgrading RN to 0.83+ (https://reactnative.dev/docs/interactionmanager)
Contributor
Author
There was a problem hiding this comment.
Created a task reminding us for usages of InteractionManager throughout the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Feature specific
This PR contains
What is the purpose of this PR?
This PR fixes an issue where using a conditional visibility on the IntroScreen widget, would cause the widget to not render.
Relevant changes
Being a rendering issue on the React Native widget code, the provided fix was to use the React Native Interaction Manager to queue the visibility state change after interactions.
What should be covered while testing?
Testing the reproduction scenario from the related ticket on Android and iOS.