Update GitHub client to improve failure handling #11553
Open
+86
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the reliability and maintainability of the
GithubClientclass by introducing a generic HTTP request retry mechanism with exponential backoff and refactoring existing methods to use this new logic. The changes also enhance code documentation for better clarity.Key improvements:
Resilience and Reliability:
executeWithRetrymethod toGithubClientthat wraps HTTP requests with retry logic, including exponential backoff and jitter, to handle transient errors more gracefully. This method also logs telemetry events on failure.Refactoring and Code Simplification:
getLatestAzureMcpReleaseanddownloadToFilemethods to use the newexecuteWithRetrymethod, reducing code duplication and improving error handling.Documentation and Readability:
GithubClient, making the purpose and usage of the class and its methods clearer for future maintainers. [1] [2]