Skip to content

Simplify logManager configuration initialization #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomasameisel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Simplify logManager configuration initialization #1403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions wrappers/obj-c/ODWLogManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,8 @@ +(nullable ILogger *)initializeLogManager:(nonnull NSString *)tenantToken withCo
ILogger* logger = nullptr;
try
{
static ILogConfiguration logManagerConfig;

// Initializing logManager config with default configuration
auto& defaultConfig = LogManager::GetLogConfiguration();
logManagerConfig = defaultConfig;
// Get reference to the default configuration
ILogConfiguration& logManagerConfig = LogManager::GetLogConfiguration();
Copy link
Contributor Author

@thomasameisel thomasameisel Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the case, but I'd like to verify that we'll continue holding a strong reference to the default configuration object even if we don't assign it to a static variable.


// Update logManager config when custom configuration is provided.
if (config != nil && config.count > 0)
Expand Down
Loading