Skip to content

Remove interface linking for PRIVATE linkage #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjp41 merged 3 commits into from
Oct 20, 2025
Merged

Remove interface linking for PRIVATE linkage #799

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca8fbfe
Remove interface linking for PRIVATE linkage
maxtropets Oct 17, 2025
dcad0a9
Comment
maxtropets Oct 20, 2025
78550bb
Merge branch 'main' into f/help-linking
maxtropets Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,11 @@ if(NOT SNMALLOC_HEADER_ONLY_LIBRARY)
function(compile name TYPE ${ARGN})
add_library(${name} ${TYPE} ${ARGN})
target_link_libraries(${name} PRIVATE snmalloc)

# PRIVATE linking still touches INTERFACE level linking for unknown reasons.
# Check https://github.com/microsoft/snmalloc/pull/799 for details.
set_target_properties(${name} PROPERTIES INTERFACE_LINK_LIBRARIES "")

target_compile_definitions(${name} PRIVATE "SNMALLOC_USE_${SNMALLOC_CLEANUP}")

add_warning_flags(${name})
Expand Down
Loading