Fixes for updating winget from winget #5972
Open
+439
−142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4283
Change
The primary issue here is that the package update monitoring is too aggressive at shutting down, and I made it listen to signal in more cases. It really isn't a good signal for us to listen to, and was only added for the elevated Store case. The fix is to move it entirely to the Store flow, as if we are installing via MSIX we can just let the deferred registration work and if someone else is updating us then we can just listen to the proper termination signals.
I additionally noticed that the dependencies were being installed despite the fact that I definitely already had them up to date. There were a few issues here that I also fixed:
Microsoft.VCLibs.14).AppsAndFeaturesEntrieshas an MSIX type (forMicrosoft.WindowsAppRuntime.*).Validation
Added unit tests for the alternate issues.
Unfortunately, fully testing the primary issue is not feasible until we get an official build. The documented impact should be gone based on debugging the current version, but any unintended side effects will need manual testing of the build in the Store prior to expanded release.
Microsoft Reviewers: Open in CodeFlow