Add CoinType used for Ledger and encode/decode utils #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OBorce
commented
Dec 5, 2025
OBorce
commented
- also use the specific version of parity scale codec with the fix for NanoX
- also use the specific version of parrity scale codec with the fix for NanoX
ImplOfAnImpl
approved these changes
Dec 8, 2025
src/misc.rs
Outdated
Comment on lines
216
to
218
| pub fn encode_as_compact(num: u32) -> PscVec<u8> { | ||
| parity_scale_codec::Compact::<u32>::encode(&num.into()) | ||
| } |
Contributor
There was a problem hiding this comment.
This function has a generic name, but it's only defined for u32. Either make it generic over the type or at least give it a specific name, e.g. encode_u32_as_compact (though this will also look quite ugly, so plz try making it generic first).
But are all these functions really needed?
Comment on lines
+17
to
+19
| parity-scale-codec = { git = "https://github.com/paritytech/parity-scale-codec.git", rev = "5021525697edc0661591ebc71392c48d950a10b0", default-features = false, features = [ | ||
| "derive", | ||
| ] } |
Contributor
There was a problem hiding this comment.
Same comment as in mintlayer/mintlayer-trezor-firmware#24 (comment)
CI fix: hardcode a separate Rust version to use with do_checks.sh
| 11 | ||
| } | ||
|
|
||
| pub const fn address_prefix(&self, destination: &Destination) -> &'static str { |
Contributor
There was a problem hiding this comment.
Btw, it's better to accept DestinationTag here, it'll be more re-usable this way. Then, you can can call it for a destination by passing (&destination).into() or destination.discriminant()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.