refactor: use time.perf_counter for consistent and accurate benchmarking #2943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
This PR updates the timing logic in several benchmark scripts to use
time.perf_counter()instead oftime.time().Files modified:
benchmarks/python/comparative/bench_mlx.pybenchmarks/python/comparative/bench_torch.pybenchmarks/python/time_utils.pydocs/src/dev/extensions.rstexamples/python/linear_regression.pyWhy this is necessary:
time.time()can be affected by system clock updates (NTP sync), whereastime.perf_counter()is a monotonic clock that never goes backward.Checklist
pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes