Skip to content

feat(NODE-7310): Replace process.arch with os.arch() #4823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
PavelSafronov wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −6
Draft

feat(NODE-7310): Replace process.arch with os.arch() #4823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fa2e34
fix(NODE-7310): Replace process.arch with os.arch()
PavelSafronov Dec 10, 2025
0e80a82
Merge branch 'main' into NODE-7310
PavelSafronov Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cmap/handshake/client_metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export async function makeClientMetadata(
// Note: order matters, os.type is last so it will be removed last if we're at maxSize
const osInfo = new Map()
.set('name', process.platform)
.set('architecture', process.arch)
.set('architecture', os.arch())
.set('version', os.release())
.set('type', os.type());

Expand Down
10 changes: 5 additions & 5 deletions test/unit/cmap/handshake/client_metadata.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ describe('client metadata module', () => {
os: {
type: os.type(),
name: process.platform,
architecture: process.arch,
architecture: os.arch(),
version: os.release()
},
platform: `Node.js ${process.version}, ${os.endianness()}`
Expand All @@ -180,7 +180,7 @@ describe('client metadata module', () => {
os: {
type: os.type(),
name: process.platform,
architecture: process.arch,
architecture: os.arch(),
version: os.release()
},
platform: `Node.js ${process.version}, ${os.endianness()}|myPlatform`
Expand All @@ -204,7 +204,7 @@ describe('client metadata module', () => {
os: {
type: os.type(),
name: process.platform,
architecture: process.arch,
architecture: os.arch(),
version: os.release()
},
platform: `Node.js ${process.version}, ${os.endianness()}`
Expand All @@ -230,7 +230,7 @@ describe('client metadata module', () => {
os: {
type: os.type(),
name: process.platform,
architecture: process.arch,
architecture: os.arch(),
version: os.release()
},
platform: `Node.js ${process.version}, ${os.endianness()}`
Expand All @@ -249,7 +249,7 @@ describe('client metadata module', () => {
os: {
type: os.type(),
name: process.platform,
architecture: process.arch,
architecture: os.arch(),
version: os.release()
},
platform: `Node.js ${process.version}, ${os.endianness()}`
Expand Down