-
Notifications
You must be signed in to change notification settings - Fork 16
cmake: fix finding Qt private headers with Qt >=6.10 #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2cf6add to
5420bec
Compare
Signed-off-by: Andrew Udvare <audvare@gmail.com>
|
This gets past the configure stage and gets 99% into the build but fails for me: This file does exist for me at The command has these All of the If I run this manually with the above added, it compiles that file. |
Related-to: movableink/webkit#53 Signed-off-by: Andrew Udvare <audvare@gmail.com>
|
Please consider adding https://github.com/Tatsh/tatsh-overlay/blob/master/dev-qt/qtwebkit/files/qtwebkit-fix-qttestbrowser-build.patch to this PR. |
|
@Tatsh: Thank you for testing. I wasn't building with tests enabled, so I didn't catch the missing piece. Do you know for certain that |
|
I assume you mean CorePrivate. Once I ran with the GuiPrivate includes another error occurred regarding CorePrivate. |
|
@Tatsh: Yes, I did. And does it not work if you append to |
Qt private header directories only get added to the include search path
when the "Qt6::${component}Private" library is added to the target.
5420bec to
949c35a
Compare
Qt private header directories only get added to the include search path when the
Qt6::${component}Privatelibrary is added to the target.