-
Notifications
You must be signed in to change notification settings - Fork 112
feat(time): Add time restrictions and range support #2712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2712 +/- ##
============================================
+ Coverage 43.72% 43.93% +0.20%
- Complexity 921 941 +20
============================================
Files 78 78
Lines 3403 3428 +25
============================================
+ Hits 1488 1506 +18
- Misses 1915 1922 +7 🚀 New features to boost your workflow:
|
6b264a2 to
97ba57a
Compare
0259ee4 to
a7a7c77
Compare
|
@susnux the NcDateTimePickerNative doesn't show the icon on the right to open the picker anymore. Is this a bug in the vue lib? But it did work when I started working on this... So not sure... 😉 @nimishavijay what do you think about the icons for the actions? I'm not really happy with them, but didn't find better ones... |
|
Regarding the icons, I agree it's a tricky one. What do you think of this clock loader 20 and clock loader 80? And IIRC we are more and more adopting the native time picker by the browser and not the time picker component in the screenshot, which we previously had (for example, in the Calendar app we stopped using the time picker component). I would suggest using 2 native time picker fields with a "to" or "-" in the middle to indicate range and the allowed times in a subline so that it looks up-to-date :) |
|
@nimishavijay regarding the picker type: the NcDateTimePicker will stay around for ranges, that's at least what I found in the docs. So I'd like to stick with it as long as this is still possible. :)
They would have been my second choice, too |
No problem! In that case I'd suggest thinking about how we can differentiate the start and end times more, as now it is just one field and seemingly one large picker. Also FYI it looks pretty different in the style guide (I'm not sure when this change happened, maybe @susnux knows more) |
Yes, I think the style guide is already based on v9 if you don't specify v8 explicitely :) |
a7a7c77 to
9389f81
Compare
This is browser dependent as this is the native browser input and cannot be controlled by us. |
9389f81 to
e83096a
Compare
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
e83096a to
c040863
Compare
|
@nimishavijay I've changed the icons now and I think that they look much better. 👍🏻 (screenshot updated in OP) |
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codewise it seems to be fine ✅
|
@nimishavijay There's now a new feature request about switching the date/time pickers to the native ones in #2719. So we'll change that for all date/time related questions in a separate PR 👍🏻 |
This is a follow-up on #2646 to support restrictions and range for time questions.
Set question settings for minimum/maximum time values and if the user must enter a time range:

Restricted times and time range picker in submit view:

Result in summary / responses view:

