Skip to content

Conversation

@Chartman123
Copy link
Collaborator

@Chartman123 Chartman123 commented Apr 21, 2025

This fixes #1110 and #1656 and is a follow-up on #1690 by @tpokorra

@Chartman123 Chartman123 changed the title patch for AllowEdit for Forms5 feat: allow editing of submission by the user Apr 21, 2025
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch from 593625b to a1819bf Compare April 21, 2025 21:03
@Chartman123 Chartman123 added enhancement New feature or request php PHP related ticket javascript Javascript related ticket 2. developing Work in progress feature: 📊 responses & statistics feature: 📝 submitting responses labels Apr 21, 2025
@Chartman123 Chartman123 self-assigned this Apr 21, 2025
@Chartman123 Chartman123 added this to the 5.2 milestone Apr 21, 2025
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch from a1819bf to a77a31e Compare April 21, 2025 21:06
@Chartman123 Chartman123 linked an issue Apr 22, 2025 that may be closed by this pull request
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch 8 times, most recently from 54b34fc to c04154b Compare April 24, 2025 14:57
@Chartman123 Chartman123 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 24, 2025
@Chartman123 Chartman123 marked this pull request as ready for review April 24, 2025 14:58
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch from ae2dcb9 to 3f68b3a Compare April 24, 2025 16:09
@Chartman123 Chartman123 requested review from AIlkiv, Koc and susnux April 24, 2025 16:09
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch 2 times, most recently from 9b0bde4 to b581319 Compare April 24, 2025 18:36
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch 4 times, most recently from 0524520 to eb0b3e6 Compare April 24, 2025 19:38
@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 37 lines in your changes missing coverage. Please review.

Project coverage is 44.49%. Comparing base (c040863) to head (de7971b).
Report is 21 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2715      +/-   ##
============================================
+ Coverage     43.93%   44.49%   +0.55%     
- Complexity      941      974      +33     
============================================
  Files            78       79       +1     
  Lines          3428     3531     +103     
============================================
+ Hits           1506     1571      +65     
- Misses         1922     1960      +38     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch from 3e9a9c7 to fc475b5 Compare April 24, 2025 20:24
@Chartman123
Copy link
Collaborator Author

Chartman123 commented Apr 25, 2025

@tpokorra I'm now in a state for testing. Would be nice if you can also give it a try.

We changed some things:

  • We decided that every user can generally see his own submissions.
  • The allowEdit switch in the sidebar toggles the ability to edit/delete your own submissions.
  • submitMultiple is no longer disabled when allowEdit is set: As we now have the UI to show all own submissions, the user can go to the Results view and there to the Responses subview and choose from the action menu next to the submission which submission he wants to edit/delete. You're then redirected to the submit view with the additional url parameter /{submissionId}.
  • The mapping answer -> question happens in the frontend now, so that the GET submissions/{submissionId} endpoint doesn't need to know for which purpose the submission is requested.

@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch 6 times, most recently from 47d3ba3 to 38e51fe Compare May 2, 2025 08:23
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch from c4fdc55 to cc7c9f5 Compare May 6, 2025 21:13
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch from 13ed0a2 to 44f0534 Compare May 8, 2025 22:26
Signed-off-by: Timotheus Pokorra <timotheus.pokorra@solidcharity.com>
@Chartman123 Chartman123 force-pushed the feat/allowEditSubmissions branch from 44f0534 to de7971b Compare May 8, 2025 22:31
@Chartman123 Chartman123 merged commit 9745ea2 into main May 8, 2025
54 checks passed
@Chartman123 Chartman123 deleted the feat/allowEditSubmissions branch May 8, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: 📊 responses & statistics feature: 📝 submitting responses javascript Javascript related ticket php PHP related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show all own submitted entries to user Change my submitted form

4 participants