fix: prevent modifications to archived forms in ApiController and ShareApiController

[Chartman123]

This fixes #2740 by adding checks if the form is archived and not currently in the process of "un-archiving"

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

[codecov]

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 45.58%. Comparing base (bacb41f) to head (5ae62c9).
Report is 7 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2741      +/-   ##
============================================
+ Coverage     45.54%   45.58%   +0.03%     
- Complexity      977      984       +7     
============================================
  Files            79       79              
  Lines          3548     3565      +17     
============================================
+ Hits           1616     1625       +9     
- Misses         1932     1940       +8     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.