Skip to content

Conversation

@kapouer
Copy link
Contributor

@kapouer kapouer commented Dec 25, 2025

Checklist
  • npm install && npm run lint && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

url.parse is deprecated ! Let's replace it by new URL(str).pathname (ignoring search), because these are file paths.

@legendecas legendecas merged commit 3f81949 into nodejs:main Jan 4, 2026
29 checks passed
@cclauss
Copy link
Contributor

cclauss commented Jan 5, 2026

I am still seeing this warning in our GitHub Actions tests:

> node-gyp@12.1.0 test
> cross-env NODE_GYP_NULL_LOGGER=true mocha --timeout 30000 test/test-download.js test/test-*
  download
    ✔ download over http
    ✔ download over https with custom ca
    ✔ download over http with proxy
    ✔ download over http with noproxy
    ✔ download with missing cafile
    ✔ check certificate splitting
(node:2575) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors
  that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()`
  vulnerabilities.
(Use `node --trace-deprecation ...` to show where the warning was created)
    ✔ download headers (actual) (8652ms)

kapouer added a commit to kapouer/node-gyp that referenced this pull request Jan 5, 2026
kapouer added a commit to kapouer/node-gyp that referenced this pull request Jan 5, 2026
kapouer added a commit to kapouer/node-gyp that referenced this pull request Jan 5, 2026
@kapouer
Copy link
Contributor Author

kapouer commented Jan 5, 2026

@cclauss indeed, I didn't fix the url.resolve calls. I'll do a PR later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants