Skip to content

Conversation

@bjohansebas
Copy link
Member

So that in Node.js 26 these modules are no longer there, and are now internal to Node.js only instead of public.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup
  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. labels Nov 9, 2025
@bjohansebas
Copy link
Member Author

cc: @nodejs/tsc since it’s an end-of-life deprecation

@bjohansebas bjohansebas added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Nov 9, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.90%. Comparing base (83893bb) to head (7b2acf4).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60658      +/-   ##
==========================================
- Coverage   89.78%   88.90%   -0.88%     
==========================================
  Files         672      670       -2     
  Lines      203809   203786      -23     
  Branches    39183    39096      -87     
==========================================
- Hits       182980   181182    -1798     
- Misses      13166    14874    +1708     
- Partials     7663     7730      +67     
Files with missing lines Coverage Δ
lib/internal/main/mksnapshot.js 95.71% <ø> (-0.05%) ⬇️
src/node_builtins.cc 76.38% <ø> (ø)

... and 107 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjohansebas
Copy link
Member Author

cc @nodejs/crypto @nodejs/net

@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2025
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@bjohansebas
Copy link
Member Author

It looks flaky in GitHub Actions CI. Could someone rerun it, please?

@bjohansebas
Copy link
Member Author

Should I do a rebase to see if it’s still failing?

@aduh95
Copy link
Contributor

aduh95 commented Dec 27, 2025

Should I do a rebase to see if it’s still failing?

That wouldn't help (unless a fix for the flakiness had landed on main since last commit, but AFAIK that's not the case), and force us to re-review and re-run all CI jobs

@aduh95 aduh95 added the needs-citgm PRs that need a CITGM CI run. label Dec 30, 2025
@bjohansebas bjohansebas added needs-citgm PRs that need a CITGM CI run. and removed needs-citgm PRs that need a CITGM CI run. labels Jan 14, 2026
@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 20, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 20, 2026
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/60658
✔  Done loading data for nodejs/node/pull/60658
----------------------------------- PR info ------------------------------------
Title      tls: move _tls_* to end-of-life (#60658)
Author     Sebastian Beltran <bjohansebas@gmail.com> (@bjohansebas)
Branch     bjohansebas:tls_eol -> nodejs:main
Labels     tls, c++, semver-major, author ready, deprecations, needs-ci, needs-citgm
Commits    1
 - tls: move _tls_* to end-of-life
Committers 1
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/60658
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/60658
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 09 Nov 2025 21:40:41 GMT
   ✔  Approvals: 2
   ✔  - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/60658#pullrequestreview-3597808519
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/60658#pullrequestreview-3613841924
   ✘  semver-major requires at least 2 TSC approvals
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-12-20T16:15:00Z: https://ci.nodejs.org/job/node-test-pull-request/70556/
- Querying data for job/node-test-pull-request/70556/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/21187285768

@RafaelGSS RafaelGSS added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 26, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2026
@nodejs-github-bot
Copy link
Collaborator

@ChALkeR
Copy link
Member

ChALkeR commented Jan 26, 2026

Note that these weren't runtime-deprecated in 24, only in 25.
Are we sure there is no major usage in the wild?
Upd: I don't see any, so this should be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. semver-major PRs that contain breaking changes and should be released in the next major version. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants