net: add setTypeOfService and getTypeOfService to Socket #61503

amyssnippet · 2026-01-24T11:11:33Z

this PR implements socket.setTOS(tos) and socket.getTOS() in net.Socket. it needed this to support DSCP tagging (QoS) for traffic prioritization, which wasn't previously exposed in the JS API. for the implementation:

I added the logic in tcp_wrap.cc to attempt IP_TOS first, and fallback to IPV6_TCLASS if that fails. This handles both IPv4 and IPv6 sockets automatically without needing a separate flag.
Windows returns UV_ENOSYS for now since the headers/implementation differ there.
Added a new test file (test-net-socket-tos.js) to verify input validation and ensure the values are actually set on supported platforms.

Fixes: #61489

nodejs-github-bot · 2026-01-24T11:11:39Z

Review requested:

@nodejs/net

mcollina

Good work. Can you add the documentation?

test/parallel/test-net-socket-tos.js

doc/api/net.md

src/tcp_wrap.cc

test/parallel/test-net-socket-tos.js

amyssnippet · 2026-01-24T16:03:04Z

Thanks @mcollina , is this ready to be merged? Please let me know if there is anything else you need me to adjust.

src/tcp_wrap.cc

nodejs-github-bot · 2026-01-25T07:11:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71012/

ronag · 2026-01-25T10:53:10Z

@mcollina I'm confused by the CI failures. Any ideas? Or just flaky?

amyssnippet · 2026-01-27T09:02:11Z

@ronag kindly approve once again, i fixed the issue related to win vs2022 build error on my win laptop, and also i tested it here. i guess it should work, rest the rhel and linuxone test failures are flaky, i confirmed it by looking the console logs.

also i added a todo for the libuv in future. as i saw it will take time for the required api in the libuv.

libuv/libuv#5011

nodejs-github-bot · 2026-01-27T09:33:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71060/

nodejs-github-bot · 2026-01-27T14:50:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71069/

amyssnippet · 2026-01-27T16:14:54Z

i have fixed all issues from my side, on both linux and windows. all platforms are ready to get served with the 26 pre version. rest ci failures are flaky. Thanks!

addaleax · 2026-01-27T16:42:16Z

lib/net.js

+  if (options.tos !== undefined) {
+    validateInt32(options.tos, 'options.tos', 0, 255);
+  }
+  this[kSetTOS] = options.tos;


^ This isn't documented, is it? Should it also be called options.typeOfService instead of options.tos?

i have updated the net.md doc, and will roll out in the next commit. and i have kept ADDME in the version, as i dont have much knowledge about versioning, so kindly update me from your side regarding that, i am attaching a screenshot of that here and code as well

### `new net.Socket([options])`  * `options` {Object} Available options are: * `allowHalfOpen` {boolean} If set to `false`, then the socket will automatically end the writable side when the readable side ends. See [`net.createServer()`][] and the [`'end'`][] event for details. **Default:** `false`. * `blockList` {net.BlockList} `blockList` can be used for disabling outbound access to specific IP addresses, IP ranges, or IP subnets. * `fd` {number} If specified, wrap around an existing socket with the given file descriptor, otherwise a new socket will be created. * `keepAlive` {boolean} If set to `true`, it enables keep-alive functionality on the socket immediately after the connection is established, similarly on what is done in [`socket.setKeepAlive()`][]. **Default:** `false`. * `keepAliveInitialDelay` {number} If set to a positive number, it sets the initial delay before the first keepalive probe is sent on an idle socket. **Default:** `0`. * `noDelay` {boolean} If set to `true`, it disables the use of Nagle's algorithm immediately after the socket is established. **Default:** `false`. * `onread` {Object} If specified, incoming data is stored in a single `buffer` and passed to the supplied `callback` when data arrives on the socket. This will cause the streaming functionality to not provide any data. The socket will emit events like `'error'`, `'end'`, and `'close'` as usual. Methods like `pause()` and `resume()` will also behave as expected. * `buffer` {Buffer|Uint8Array|Function} Either a reusable chunk of memory to use for storing incoming data or a function that returns such. * `callback` {Function} This function is called for every chunk of incoming data. Two arguments are passed to it: the number of bytes written to `buffer` and a reference to `buffer`. Return `false` from this function to implicitly `pause()` the socket. This function will be executed in the global context. * `readable` {boolean} Allow reads on the socket when an `fd` is passed, otherwise ignored. **Default:** `false`. * `signal` {AbortSignal} An Abort signal that may be used to destroy the socket. * `typeOfService` {number} The initial Type of Service (TOS) value. * `writable` {boolean} Allow writes on the socket when an `fd` is passed, otherwise ignored. **Default:** `false`. * Returns: {net.Socket} Creates a new socket object. The newly created socket can be either a TCP socket or a streaming [IPC][] endpoint, depending on what it [`connect()`][`socket.connect()`] to.

anonrig · 2026-01-27T16:49:01Z

lib/net.js

+  if (!this._handle) {
+    this[kSetTOS] = tos;
+    return this;
+  }
+
+  if (!this._handle.setTypeOfService) {
+    this[kSetTOS] = tos;
+    return this;
+  }


Suggested change

if (!this._handle) {

this[kSetTOS] = tos;

return this;

}

if (!this._handle.setTypeOfService) {

this[kSetTOS] = tos;

return this;

}

if (!this._handle?.setTypeOfService) {

this[kSetTOS] = tos;

return this;

}

lib/net.js

anonrig · 2026-01-27T16:50:15Z

src/tcp_wrap.h

@@ -74,6 +74,8 @@ class TCPWrap : public ConnectionWrap<TCPWrap, uv_tcp_t> {
  static void New(const v8::FunctionCallbackInfo<v8::Value>& args);
  static void SetNoDelay(const v8::FunctionCallbackInfo<v8::Value>& args);
  static void SetKeepAlive(const v8::FunctionCallbackInfo<v8::Value>& args);
+  static void SetTOS(const v8::FunctionCallbackInfo<v8::Value>& args);


Can we use SetTypeOfService rather than these abbreviations please?

i was on the way to that, i am parallely doing the changes on my 3 machines, win, linux and mac. constantly building, linting, formatting on a single change, will roll out soon

juanarbol

I think windows may need a different implementation, with a different API.

Do not use. Type of Service (TOS) settings should only be set using the Quality of Service API. See Differentiated Services in the Quality of Service section of the Platform SDK for more information.

https://learn.microsoft.com/en-us/windows/win32/winsock/ipproto-ip-socket-options

juanarbol · 2026-01-27T18:18:13Z

src/tcp_wrap.cc

+
+  // 3. Perform the system call (Platform specific casting)
+#ifdef _WIN32
+  if (setsockopt(reinterpret_cast<::SOCKET>(fd),


Just FYI, windows is not gonna be very happy about this

Do not use. Type of Service (TOS) settings should only be set using the Quality of Service API. See Differentiated Services in the Quality of Service section of the Platform SDK for more information.

Refs: https://learn.microsoft.com/en-us/windows/win32/winsock/ipproto-ip-socket-options

so we should skip windows with an UV_ENOSYS, function not implemented on windows?? as i guess its libuv's job, and have you started working on that??

That method works exactly as you expect. The warning is about API design and future-proofing, not that the socket option is broken.

I would argue it's fine to use for now.

nodejs-github-bot · 2026-01-28T06:40:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71088/

amyssnippet · 2026-01-28T12:01:55Z

so is everything fine and ready to merge???

net: add setTOS and getTOS to Socket

eb53d09

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 24, 2026

mcollina requested changes Jan 24, 2026

View reviewed changes

test/parallel/test-net-socket-tos.js Outdated Show resolved Hide resolved

mcollina requested a review from ronag January 24, 2026 13:16

mcollina added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 24, 2026

amyssnippet added 3 commits January 24, 2026 19:08

added doc

9e7a183

fixed some lint issues

14b3fb0

already complete with validation and platform specific tests

f339cd0

amyssnippet requested a review from mcollina January 24, 2026 13:41

amyssnippet mentioned this pull request Jan 24, 2026

socket.setTOS #61489

Open

mcollina requested changes Jan 24, 2026

View reviewed changes

doc/api/net.md Outdated Show resolved Hide resolved

doc/api/net.md Outdated Show resolved Hide resolved

src/tcp_wrap.cc Show resolved Hide resolved

test/parallel/test-net-socket-tos.js Outdated Show resolved Hide resolved

amyssnippet added 2 commits January 24, 2026 19:52

added: REPLACEME

d32f212

common.mustCall used

71ecbd7

amyssnippet requested a review from mcollina January 24, 2026 14:34

ronag approved these changes Jan 24, 2026

View reviewed changes

ronag reviewed Jan 24, 2026

View reviewed changes

src/tcp_wrap.cc Outdated Show resolved Hide resolved

ronag mentioned this pull request Jan 24, 2026

Type of Service (IP prioritization) nodejs/undici#4765

Open

undo: unrelated header was removed irrelevantly

c0407b2

amyssnippet force-pushed the fix/61489 branch from 42d5142 to c0407b2 Compare January 25, 2026 05:03

amyssnippet requested a review from ronag January 25, 2026 05:05

ronag approved these changes Jan 25, 2026

View reviewed changes

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 25, 2026

ronag mentioned this pull request Jan 25, 2026

Feature Request - Allow setting ToS on socket (rather; wrap getNativeHandle() and let you apply whatever options you wish) uNetworking/uWebSockets.js#1205

Open

win vs2022 ci fix

2bb4591

amyssnippet force-pushed the fix/61489 branch from ac01361 to 2bb4591 Compare January 27, 2026 08:29

amyssnippet requested review from addaleax, ronag and santigimeno January 27, 2026 08:30

added: todo for libuv api

a2d4c36

ronag approved these changes Jan 27, 2026

View reviewed changes

ronag changed the title ~~net: add setTOS and getTOS to Socket~~ net: add setTypeOfService and getTypeOfService to Socket Jan 27, 2026

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2026

addaleax approved these changes Jan 27, 2026

View reviewed changes

fixed:win vs2022 lint ci

b04b62f

amyssnippet requested review from addaleax and ronag and removed request for ronag January 27, 2026 16:16

addaleax reviewed Jan 27, 2026

View reviewed changes

anonrig reviewed Jan 27, 2026

View reviewed changes

juanarbol reviewed Jan 27, 2026

View reviewed changes

ronag approved these changes Jan 28, 2026

View reviewed changes

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2026

amyssnippet closed this Jan 28, 2026

amyssnippet reopened this Jan 28, 2026

Uh oh!

net: add setTypeOfService and getTypeOfService to Socket #61503

Are you sure you want to change the base?

net: add setTypeOfService and getTypeOfService to Socket #61503

Conversation

amyssnippet commented Jan 24, 2026 • edited by mcollina Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 24, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amyssnippet commented Jan 24, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 25, 2026

Uh oh!

ronag commented Jan 25, 2026

Uh oh!

amyssnippet commented Jan 27, 2026

Uh oh!

nodejs-github-bot commented Jan 27, 2026

Uh oh!

nodejs-github-bot commented Jan 27, 2026

Uh oh!

amyssnippet commented Jan 27, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juanarbol left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 28, 2026

Uh oh!

amyssnippet commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

amyssnippet commented Jan 24, 2026 •

edited by mcollina

Loading