-
-
Notifications
You must be signed in to change notification settings - Fork 0
doc(proposal): flaky
#4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JakobJingleheimer
wants to merge
1
commit into
main
Choose a base branch
from
proposals/flaky
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # Feature proposal: `flaky` | ||
|
|
||
| This flag causes a test-case or suite to be re-run a number of times until it either passes or has not passed after the final re-try. | ||
|
|
||
| ## API | ||
|
|
||
| ```js | ||
| describe.flaky('some temperamental thing', () => { | ||
| it('may take several times', () => {…}); | ||
|
|
||
| it('may also take several times', () => {…}); | ||
| }); | ||
|
|
||
| it.flaky('should do something', () => {…}); | ||
| ``` | ||
|
|
||
| ```js | ||
| describe('some temperamental thing', { flaky: true }, () => { | ||
| it('may take several times', () => {…}); | ||
|
|
||
| it('may also take several times', () => {…}); | ||
| }); | ||
|
|
||
| it('may take several times', { flaky: true }, () => {…}); | ||
| it('may also take several times', { flaky: 100 }, () => {…}); | ||
| ``` | ||
|
|
||
| When `flaky` is `true`, the test harness re-tries the suite or test-case up to the default number of times (eg 20), inclusive. | ||
|
|
||
| When `flaky` is falsy (the default), the test harness does not re-try the suite or test-case. | ||
|
|
||
| When `flaky` is a positive integer, the test harness re-tries the suite or test-case up to the specified number of times, inclusive. | ||
|
|
||
| When `flaky` is a non-positive integers or non-boolean, the test harness emits/throws an error. | ||
|
|
||
| When both the suite and an included test-case specify the `flaky` flag, the test-case's `flaky` value wins. | ||
|
|
||
| ## Output | ||
|
|
||
| When a suite or test-case is marked `flaky`, the number of re-tries taken to achieve a passing result is reported with that suite or test-case. | ||
|
|
||
| The summary also lists the total number of _test-cases_ marked flaky; a "flaky" suite containing 10 test-cases increases the total flaky count by 10. | ||
|
|
||
| ### Example: TAP | ||
|
|
||
| ``` | ||
| ok 1 - may take several times # FLAKY 42 re-tries | ||
|
|
||
| tests 1 | ||
| suites 1 | ||
| pass 1 | ||
| fail 0 | ||
| flaky 1 | ||
| cancelled 0 | ||
| skipped 0 | ||
| todo 0 | ||
| ``` | ||
|
|
||
| ## Notes | ||
|
|
||
| Feature documentation (possibly in a Learn article rather than API documentation) warns users of common caveats related to re-tries (e.g. [idempotence](https://en.wikipedia.org/wiki/Idempotence), statefulness). | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that if we provide a default, we should also provide a way to define a global default. It could be a "phase 2" implementation, but I would suggest thinking about it!
(In any case I would also suggest defining an initial default of around 5 👀 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we do via the usual ENV + flag + configFile? I was hoping to crowd-source ideas for that 🙂