Skip to content

Conversation

@bpalmeiro
Copy link
Collaborator

This function is meant to model the sensor responses when they work in avalanche mode.

@bpalmeiro bpalmeiro force-pushed the fingersignalfunction branch from dbc8623 to 73a2279 Compare October 29, 2024 20:47
@jwaiton
Copy link
Member

jwaiton commented Nov 5, 2024

I've added docstrings, comments and some alterations in logic.

I've also added this catch statement to avoid an issue when the poisson mu is set to zero.

# Collect the position and amplitudes of the finger plot peaks

This doesnt feel elegant, and also possibly doesn't match what you'd expect.

@jwaiton jwaiton added the enhancement New feature or request label Nov 25, 2024
@bpalmeiro
Copy link
Collaborator Author

I've added docstrings, comments and some alterations in logic.

I've also added this catch statement to avoid an issue when the poisson mu is set to zero.

# Collect the position and amplitudes of the finger plot peaks

This doesnt feel elegant, and also possibly doesn't match what you'd expect.

My only concern with this (that is not decoupled from the previous implementation, I believe) is that when you do this, then sigmaq becomes a floating parameter, and that can be problematic when fitting, but I don't have a good solution rn sadly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants