chore: streaming tts changes #164
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/tts/talk.py
Outdated
| ======= | ||
| parser.add_argument("--text-list", type=Path, default=None, help="A file path to a list of texts to synthesize.") | ||
| parser.add_argument("--stream", action="store_true", help="If this option is set, then streaming synthesis is applied. Streaming means that audio is yielded as it gets ready. If `--stream` is not set, then a synthesized audio is returned in 1 response only when all text is processed.") | ||
| >>>>>>> de4d527 (chore: streaming tts changes) |
Contributor
There was a problem hiding this comment.
the stream argument is already present, this got carried over with merge conflict
Contributor
Author
There was a problem hiding this comment.
done, during rebase it got added
scripts/tts/talk.py
Outdated
| help="Transcript corresponding to Zero shot audio prompt.", | ||
| ) | ||
| ======= | ||
| parser.add_argument("--text-list", type=Path, default=None, help="A file path to a list of texts to synthesize.") |
Contributor
There was a problem hiding this comment.
can we keep argument name as --text-file to be same as tts perf client?
mohnishparmar
force-pushed
the
streaming_input
branch
from
fdff99d to
9b4b582
Compare
|
|
||
| if args.text_file is not None: | ||
| with open(args.text_file, 'r') as file: | ||
| text_list = [line.split("|")[1].strip() for line in file.readlines()] |
Contributor
There was a problem hiding this comment.
Do we document somewhere the text file must have each line pipe separated? Can we not add handling for format without |?
CPP client is flexible enough to handle both formats of text_file, text with <audio_file_name>|<transcript> and just <transcript>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.