Check message with UUID exists in the DB when spooling and remove the…

[norkans7]

… spool file

[Copilot]

Pull Request Overview

This PR adds duplicate message checking functionality to prevent reprocessing messages that already exist in the database. When message insertion fails during spooling, the system now checks if the message UUID already exists before considering it a failure.

• Added a checkDuplicate function to query for existing messages by UUID
• Modified the spool file flushing logic to check for duplicates when message insertion fails

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The error message is misleading. When id != models.NilMsgID, there's no error in checking for duplicates - a duplicate was successfully found. The error logging should only occur when err != nil.

Suggested change

	if id == models.NilMsgID || err != nil {
	if err != nil {

[codecov]

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.63%. Comparing base (184e19e) to head (f6247e5).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
backends/rapidpro/msg.go	0.00%	20 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #899      +/-   ##
==========================================
- Coverage   67.72%   67.63%   -0.10%     
==========================================
  Files         118      118              
  Lines       13156    13174      +18     
==========================================
  Hits         8910     8910              
- Misses       3577     3595      +18     
  Partials      669      669              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The comment 'fail? oh well, we'll try again later' is inconsistent with the actual behavior. The function returns the error immediately, preventing retry, but the comment suggests it will retry later.

Suggested change

	return dupErr // fail? oh well, we'll try again later
	}
	if id == models.NilMsgID {
	return err // fail? oh well, we'll try again later
	return dupErr // return error immediately; no retry attempted here
	}
	if id == models.NilMsgID {
	return err // return error immediately; no retry attempted here

[rowanseymour]

I feel like this just hides the problem.. I wanna see if updating sqlx or the underlying postgres driver can make that query behave properly when the context has timed out.