-
Notifications
You must be signed in to change notification settings - Fork 31
Start testing on django 6.0 #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR converts the GitHub Actions CI workflow from using actions/setup-python to using Docker containers with Python images. The change eliminates the need for the Python setup action by running jobs directly in containerized Python environments.
Key Changes:
- Replaced
actions/setup-pythonwith container-based execution using Python Docker images - Simplified Python version specification in the matrix from "3.11.x" format to "3.11" format
- Moved
runs-ondeclaration before thecontainerconfiguration for better readability
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:23
- When using a container for the job, the postgres service will not be accessible at "localhost:5432" as expected. In GitHub Actions, when the job runs in a container, services are accessible using their service name as the hostname (e.g., "postgres" instead of "localhost"). You need to ensure your database configuration uses "postgres" as the hostname, or configure the service networking appropriately. Additionally, you may need to use the service container's internal port (5432) without port mapping when both the job and service run in containers.
services:
postgres:
image: postgres:15-alpine
env:
POSTGRES_DB: smartmin
POSTGRES_USER: smartmin
POSTGRES_PASSWORD: nyaruka
ports:
- 5432:5432
options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
80dd045 to
845276c
Compare
845276c to
4fe23c5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 74.59% 74.59%
=======================================
Files 24 24
Lines 2051 2051
=======================================
Hits 1530 1530
Misses 521 521 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.