Skip to content

Conversation

@norkans7
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings December 17, 2025 11:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR converts the GitHub Actions CI workflow from using actions/setup-python to using Docker containers with Python images. The change eliminates the need for the Python setup action by running jobs directly in containerized Python environments.

Key Changes:

  • Replaced actions/setup-python with container-based execution using Python Docker images
  • Simplified Python version specification in the matrix from "3.11.x" format to "3.11" format
  • Moved runs-on declaration before the container configuration for better readability
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:23

  • When using a container for the job, the postgres service will not be accessible at "localhost:5432" as expected. In GitHub Actions, when the job runs in a container, services are accessible using their service name as the hostname (e.g., "postgres" instead of "localhost"). You need to ensure your database configuration uses "postgres" as the hostname, or configure the service networking appropriately. Additionally, you may need to use the service container's internal port (5432) without port mapping when both the job and service run in containers.
    services:
      postgres:
        image: postgres:15-alpine
        env:
          POSTGRES_DB: smartmin
          POSTGRES_USER: smartmin
          POSTGRES_PASSWORD: nyaruka
        ports:
          - 5432:5432
        options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@norkans7 norkans7 force-pushed the ci-containers branch 5 times, most recently from 80dd045 to 845276c Compare December 17, 2025 15:42
@norkans7 norkans7 changed the title Adjust GH action to use containers Start testing on django 6.0 Dec 17, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.59%. Comparing base (24f3d71) to head (0e90405).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   74.59%   74.59%           
=======================================
  Files          24       24           
  Lines        2051     2051           
=======================================
  Hits         1530     1530           
  Misses        521      521           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants