Fix/tagged struct expr handling #67
Conversation
The catch-all IN clause handler was wrapping SubQuery expressions in
JSON_EACH(), producing invalid SQL like:
WHERE id IN (SELECT value FROM JSON_EACH(?))
This adds a specific pattern match for %Ecto.SubQuery{} before the
catch-all, generating proper inline subqueries:
WHERE id IN (SELECT s0.id FROM table AS s0 WHERE ...)
Also adds a general SubQuery expression handler that properly resolves
parent query aliases and combination queries.
This fixes compatibility with libraries like Oban that use subqueries
in UPDATE...WHERE id IN (subquery) patterns.
Ecto's query planner transforms {:type, _, [expr, type]} AST nodes
into %Ecto.Query.Tagged{} structs. The SQL generator only handled
the pre-planning tuple form, causing type-wrapped fragments (e.g.
type(fragment(...), :integer)) to fall through to the catch-all
expr clause which rendered a single '?' placeholder. This caused
parameter count mismatches with Hrana/Turso.
Fixes Oban Web JobQuery.limit_query crash on completed jobs page.
WalkthroughThe update modifies internal logic in the Ecto LibSQL adapter to enhance SQL generation for Changes
Sequence Diagram(s)Skipped (diagram criteria not met, as only one file and no three-component interaction). Estimated code review effort🎯 4 (Complex) | ⏱️ ~40 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
Ecto's query planner transforms {:type, _, [expr, type]} AST nodes into %Ecto.Query.Tagged{} structs. The SQL generator only handled the pre-planning tuple form, causing type-wrapped fragments (e.g. type(fragment(...), :integer)) to fall through to the catch-all expr clause which rendered a single '?' placeholder. This caused parameter count mismatches with Hrana/Turso.
Fixes Oban Web JobQuery.limit_query crash on '$state' jobs page.
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.