feat: vertically scale cluster machine; reduce overall ec2 count #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Run Output 🤖Format and Style 🖌
|
| Pusher | @DecFox |
| Action | pull_request |
| Environment | dev |
| Workflow | .github/workflows/check_terraform.yml |
| Last updated | Thu, 20 Nov 2025 13:16:00 GMT |
LDiazN
reviewed
Nov 21, 2025
| asg_min = 2 | ||
| asg_max = 10 | ||
| asg_desired = 7 | ||
| asg_min = 1 |
Contributor
There was a problem hiding this comment.
min should be 2 to have one instance per AZ
LDiazN
reviewed
Nov 21, 2025
| asg_min = 2 | ||
| asg_max = 5 | ||
| asg_desired = 3 | ||
| asg_min = 1 |
LDiazN
reviewed
Nov 21, 2025
| key_name = module.adm_iam_roles.oonidevops_key_name | ||
| ecs_cluster_id = module.ooniapi_cluster.cluster_id | ||
| task_memory = 128 | ||
| task_memory = 512 |
Contributor
There was a problem hiding this comment.
I would try with 256 first to see how it behaves, ooniprobe doesn't needs that much memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We experienced an increase in the avg INSERT query latency during high measurement volume after scaling the ecs cluster to include more machines. This could be due to the db being a bottleneck in terms of the number of client machines in the cluster. To this end, this diff reduces the number of machines and spins up larger ones instead so the total count of machines stays low.