Skip to content

Conversation

@mschoettle
Copy link
Member

@mschoettle mschoettle commented Dec 1, 2025

  • Service account creation with required roles/permissions
  • API key creation with restrictions
  • retrieval of Apple Push notification service certificate and private key

@mschoettle mschoettle marked this pull request as ready for review December 2, 2025 17:45
@mschoettle
Copy link
Member Author

Should we add a link to restricting the permissions to the local setup?

@staceybeard
Copy link
Member

Should we add a link to restricting the permissions to the local setup?

Do you mean in local-dev-setup? We could mark it as optional. But if it's a truly local setup, it might not be necessary.

@staceybeard
Copy link
Member

@mschoettle Reminder in case you have time to get back to this.

@mschoettle
Copy link
Member Author

Should we add a link to restricting the permissions to the local setup?

Do you mean in local-dev-setup? We could mark it as optional. But if it's a truly local setup, it might not be necessary.

Yes. I am actually thinking that the whole setting up of a Firebase project could go into the install guide and then just link to it from the local setup. Right now it is a bit odd that the install guide links to the local setup guide.

What do you think?

@mschoettle
Copy link
Member Author

@staceybeard I can't re-request the review so here is my comment doing so :D

@staceybeard
Copy link
Member

I am actually thinking that the whole setting up of a Firebase project could go into the install guide and then just link to it from the local setup.

That makes sense 👍 If you prefer organizing it that way, go for it.

I'd still leave the service account and API key restrictions where they are, and either not link to them from local-dev-setup, or link to them but mark them as optional.

@mschoettle
Copy link
Member Author

I am actually thinking that the whole setting up of a Firebase project could go into the install guide and then just link to it from the local setup.

That makes sense 👍 If you prefer organizing it that way, go for it.

I'd still leave the service account and API key restrictions where they are, and either not link to them from local-dev-setup, or link to them but mark them as optional.

Going to merge this first and create a follow up PR to move it into its own page.

@mschoettle mschoettle merged commit dadc71c into main Dec 16, 2025
5 checks passed
@mschoettle mschoettle deleted the add-deployment-info branch December 16, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants