-
Notifications
You must be signed in to change notification settings - Fork 7
Edit ADRIA.Domain() and generalize to incorporate loading of GBR-wide domain package #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d131194 to
1b17468
Compare
DanTanAtAims
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can fix the rest of the issues if you would like.
Line 916, (not edited in the pull request), assumes a column named cluster_id is in the geopackage. It should be getting the column name from the environmental layer.
If not DHW is initially loaded, sampling will assume there are 50 dhw scenarios when there are only 10.
Cyclones are loaded as categories and need to be converted to mortalities.
Thanks Dan. Does this mean that currently cyclones are not going to be correctly applied as they are in the Moore scale domain runs? |
I see now the .nc data is cyclone category data from RME. Does this have to be converted to mortality values using methods in rrap_dg package before it can be used in ADRIADomain runs? |
store number of dhw scenarios in enviro layer
b66a5c9 to
79cba60
Compare
|
Should be ready for final review. The domain is available on teams in the dom = ADRIA.load_domain("path")In the end I decided to convert the cyclones categories to mortality's outside of ADRIA, so that when we eventually update the domain with different cyclone data, it doesn't need to be cyclone categories. |
Minor changes required to generalize code away from reef cluster/site level Domains and allow GBR-wide ADRIADomains to be accepted.