Skip to content

Conversation

@eco-ben
Copy link
Collaborator

@eco-ben eco-ben commented Jan 8, 2025

Minor changes required to generalize code away from reef cluster/site level Domains and allow GBR-wide ADRIADomains to be accepted.

@eco-ben eco-ben self-assigned this Jan 8, 2025
@eco-ben eco-ben added the enhancement New feature or request label Jan 8, 2025
@DanTanAtAims DanTanAtAims self-assigned this Jan 28, 2025
@eco-ben eco-ben force-pushed the GBR-wide-ADRIADomain branch from d131194 to 1b17468 Compare March 2, 2025 13:44
Copy link
Contributor

@DanTanAtAims DanTanAtAims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can fix the rest of the issues if you would like.

Line 916, (not edited in the pull request), assumes a column named cluster_id is in the geopackage. It should be getting the column name from the environmental layer.

If not DHW is initially loaded, sampling will assume there are 50 dhw scenarios when there are only 10.

Cyclones are loaded as categories and need to be converted to mortalities.

@eco-ben
Copy link
Collaborator Author

eco-ben commented Mar 4, 2025

Cyclones are loaded as categories and need to be converted to mortalities.

Thanks Dan. Does this mean that currently cyclones are not going to be correctly applied as they are in the Moore scale domain runs?

@eco-ben
Copy link
Collaborator Author

eco-ben commented Mar 4, 2025

Cyclones are loaded as categories and need to be converted to mortalities.

Thanks Dan. Does this mean that currently cyclones are not going to be correctly applied as they are in the Moore scale domain runs?

I see now the .nc data is cyclone category data from RME. Does this have to be converted to mortality values using methods in rrap_dg package before it can be used in ADRIADomain runs?
I will continue using my GBR-wide ADRIADomain running with 0 cyclone mortality for now.

@DanTanAtAims DanTanAtAims force-pushed the GBR-wide-ADRIADomain branch from b66a5c9 to 79cba60 Compare March 24, 2025 05:47
@DanTanAtAims
Copy link
Contributor

DanTanAtAims commented Mar 24, 2025

@ConnectedSystems

Should be ready for final review. The domain is available on teams in the ADRIA Domain Data folder called GBR_2024_10_15

dom = ADRIA.load_domain("path")

In the end I decided to convert the cyclones categories to mortality's outside of ADRIA, so that when we eventually update the domain with different cyclone data, it doesn't need to be cyclone categories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants