-
Notifications
You must be signed in to change notification settings - Fork 7
Add variable density #959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DanTanAtAims
wants to merge
42
commits into
main
Choose a base branch
from
add-variable-density
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add variable density #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sity If Density cannot be accommodated for the coral volume, update the target density to the max possible for the available space
Add use of function to update number of sites/ density to accommodate coral volume
fix load domain error
fix incorrect tests in seeding strategies
add tests for fix factors for categorical parameters
Plus formatting
9d521c4 to
a2e37a2
Compare
Collaborator
|
Packages seem to have reverted to Julia v1.11.0 Could you update to latest in the v1.11.x series please? The other quick comment before I start a full review is to use symbols, not strings, for the seeding strategies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds different seeding strategies interventions that can be changed the same way decision methods can be changed.
Possible Strategies
"CAP_DENSITY"- Deploy at the given number of corals across the given number of locations, however if the deployment would exceed a given density it will reduce the number of corals deployed so as not to exceed the given density."VARY_LOCATIONS"- Deploy at the number of locations that gives the closest deployment density for the given number of corals to deploy."VARY_N_SEEDED"- Change the number of corals deployed to meet the deployment density at all locations. For examples deploy 5 corals per m^2 at all considered deployment locations . If there is 100 m^2 available summed across all locations it will deploy 5000 corals."VARY_SEED_DENSITY"- Change the seeding density to deploy the given number of corals at the given number of deployment locations.The script below runs scenarios using different strategies and the plots show what the total deployments were,.