Skip to content

fix(d3plot): correct printf-style formatting in debug logs #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codie3611 merged 1 commit into from
Dec 21, 2025
Merged

fix(d3plot): correct printf-style formatting in debug logs #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lasso/dyna/d3plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6228,7 +6228,7 @@ def write_d3plot(
# write geometry file
with open_file_or_filepath(filepath, "wb") as fp:
n_bytes_written = 0
msg = "wrote {0} after {1}."
msg = "wrote %s after %s."

# header
n_bytes_written += self._write_header(fp, write_settings)
Expand Down Expand Up @@ -6309,7 +6309,7 @@ def write_d3plot(
n_bytes_written += fp.write(zero_bytes)
LOGGER.debug(msg, n_bytes_written, "_zero_byte_padding")

msg = "Wrote {0} bytes to geometry file."
msg = "Wrote %s bytes to geometry file."
LOGGER.debug(msg, n_bytes_written)

# Extra Data Types (for multi solver output)
Expand Down
3 changes: 2 additions & 1 deletion test/unit_tests/dyna/test_d3plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,8 @@ def test_write(self):

# rewrite d3plot
out_filepath = os.path.join(dirpath, "yay.d3plot")
d3plot1.write_d3plot(out_filepath)
with self.assertLogs("lasso.dyna.d3plot", level="DEBUG"):
d3plot1.write_d3plot(out_filepath)

# read it in again and compare
d3plot2 = D3plot(out_filepath, **d3plot_kwargs)
Expand Down