golabels: handle RIP relative offset #1006
Open
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
commented
Dec 5, 2025
| return it | ||
| } | ||
|
|
||
| func (i *Interpreter) PC() int { |
fabled
reviewed
Dec 7, 2025
Comment on lines
+90
to
+92
| if prevOp.Op == x86asm.MOV { | ||
| if dst, ok := prevOp.Args[0].(x86asm.Reg); ok && dst == mem.Base { | ||
| if prevMem, ok := prevOp.Args[1].(x86asm.Mem); ok && prevMem.Base == x86asm.RIP { |
Contributor
There was a problem hiding this comment.
This looks overly complex, and tracking prevOp should be unneeded.
You should be able to just get the register from this mov and then use it.Regs.Get(reg) to get the register value which resolves directly to the virtual memory address since commit fac83fa. That should also handle the rip relative logic completely transparently and only the VritualMemory read is needed here. Or did I miss something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #890 as #984 got merged.