WRKLDS-1766: postpone the removal of the DeploymentConfig API

[atiratree]

No description provided.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@atiratree: This pull request references WRKLDS-1766 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @atiratree! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request updates the prerelease lifecycle annotations and APILifecycleRemoved() method return values across multiple types in the apps/v1 package. The removal version was changed from (4, 10000) to (5, 10000) for DeploymentConfig, DeploymentConfigList, DeploymentConfigRollback, DeploymentLog, DeploymentLogOptions, and DeploymentRequest. The modifications affect only the deprecation/removal lifecycle metadata in both types.go and zz_prerelease_lifecycle_generated.go, with no changes to type signatures or control flow logic.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No description was provided by the author, making it impossible to assess relevance to the changeset.	Add a pull request description explaining the rationale for postponing the DeploymentConfig API removal and any related context.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title clearly and specifically describes the main change: postponing the removal of the DeploymentConfig API, which directly aligns with updating removal versions from 4.10000 to 5.10000.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between a0ffeb3 and 6a30f3a.

📒 Files selected for processing (2)

• apps/v1/types.go
• apps/v1/zz_prerelease_lifecycle_generated.go

🔇 Additional comments (3)

apps/v1/types.go (2)

19-19: Annotation updates look correct.

The prerelease-lifecycle-gen:removed annotation is consistently updated from 4.10000 to 5.10000 for DeploymentConfig. This change correctly aligns with the PR objective to postpone API removal to a future major version.

---

410-410: Consistent annotation updates across all related types.

The removal version annotations for DeploymentConfigList, DeploymentConfigRollback, DeploymentRequest, DeploymentLog, and DeploymentLogOptions are all consistently updated to 5.10000, matching the DeploymentConfig change.

Also applies to: 430-430, 465-465, 489-489, 502-502

apps/v1/zz_prerelease_lifecycle_generated.go (1)

22-24: Generated code is in sync with source annotations.

The APILifecycleRemoved() return values are correctly updated to (5, 10000) for all six types, matching the corresponding +k8s:prerelease-lifecycle-gen:removed=5.10000 annotations in types.go. The generated code appears to have been properly regenerated.

Also applies to: 40-42, 58-60, 76-78, 94-96, 112-114

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[atiratree]

/hold

[openshift-ci]

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[everettraven]

IIRC the outcome from the arch call was to use 6.0?