Skip to content

NO-JIRA: [release-4.21] fix: remove unnecessary package.lock #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jgbernalp wants to merge 4 commits into
base: release-4.21
Choose a base branch
from
Open

NO-JIRA: [release-4.21] fix: remove unnecessary package.lock #729

jgbernalp wants to merge 4 commits into from

Conversation

@jgbernalp
Copy link
Contributor

@jgbernalp jgbernalp commented Jan 12, 2026

No description provided.

@jgbernalp
fix: remove unnecessary package.lock
9007e93 
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 12, 2026
@PeterYurkovich
Copy link
Contributor

PeterYurkovich commented Jan 12, 2026 •
edited
Loading

TY, feel free to change it to not be a draft whenever

@PeterYurkovich
Copy link
Contributor

PeterYurkovich commented Jan 12, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PeterYurkovich
Copy link
Contributor

PeterYurkovich commented Jan 12, 2026

I just realized that we found the same dangling file at the same time and both went to delete it, if you want to just use the cherry pick from the other PR thats fine too

@jgbernalp
Copy link
Contributor Author

jgbernalp commented Jan 12, 2026

I'll keep this one. I created this PR as WIP because I'm testing a failure on the okd-scos-images for this target branch. When creating cherry picks the bot gets the cluster permissions over the namespace created for testing and we are not able to look at the log details. Unless I missed something...

@jgbernalp jgbernalp marked this pull request as ready for review January 12, 2026 17:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2026
@jgbernalp
Copy link
Contributor Author

jgbernalp commented Jan 12, 2026

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2026
@etmurasaki
Copy link
Contributor

etmurasaki commented Jan 12, 2026

/test e2e-monitoring

@jgbernalp
feat: use esbuild-loader, add push manifest command to makefile
8de9462 
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@jgbernalp
fix esbuild optional dependencies for cross arch builds
6210f83 
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2026

New changes are detected. LGTM label has been removed.

@jgbernalp
Copy link
Contributor Author

jgbernalp commented Jan 13, 2026

/test okd-scos-images

1 similar comment
@jgbernalp
Copy link
Contributor Author

jgbernalp commented Jan 13, 2026

/test okd-scos-images

@jgbernalp jgbernalp force-pushed the remove-unnecesary-package-lock-4-21 branch from 1ed5ef2 to ed48fbe Compare January 13, 2026 10:56
@jgbernalp
Copy link
Contributor Author

jgbernalp commented Jan 14, 2026

/test okd-scos-images

@jgbernalp
debug art dockerfile 1
55b5802 
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@jgbernalp jgbernalp force-pushed the remove-unnecesary-package-lock-4-21 branch from ed48fbe to 55b5802 Compare January 14, 2026 09:23
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2026

@jgbernalp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-images 55b5802 link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgbernalp jgbernalp changed the title fix: remove unnecessary package.lock NO-JIRA: [release-4.21] fix: remove unnecessary package.lock Jan 14, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 14, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2026

@jgbernalp: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etmurasaki etmurasaki Awaiting requested review from etmurasaki

@PeterYurkovich PeterYurkovich Awaiting requested review from PeterYurkovich

Assignees

@PeterYurkovich PeterYurkovich

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jgbernalp @PeterYurkovich @etmurasaki @openshift-ci-robot