-
Notifications
You must be signed in to change notification settings - Fork 20
Feat: add support for OCI models in LangGraph adapter #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c7c7bfa to
72128c5
Compare
|
Internal regression failed: Build ID #140 |
|
Internal regression failed: Build ID #142 |
|
Internal regression succeeded 🍏: Build ID #143 |
| langgraph==0.6.11 | ||
| langchain-core==0.3.75 | ||
| langchain-openai==0.3.30 | ||
| langchain-core==0.3.78 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To check if this is OK to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need those versions specifically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I had to change it because langchain-oci 0.2.0 depends on langchain-core>=0.3.78 and langchain-openai >=0.3.35. The installation complains if I did not change these constraints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this interact with the upgrade to langchain/langgraph 1.0? To avoid requiring approvals for multiple versions, I would propose to focus on the upgrade to langgraph 1.0 and then update this PR based on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade to langgraph 1.0 will require upgrades to these packages as well, so I also agree it's a good idea to complete it first
pyagentspec/tests/adapters/langgraph/llms/test_llm_conversion.py
Outdated
Show resolved
Hide resolved
pyagentspec/src/pyagentspec/adapters/langgraph/_agentspecconverter.py
Outdated
Show resolved
Hide resolved
6181881 to
acbf29e
Compare
|
Internal regression succeeded 🍏: Build ID #149 |
acbf29e to
2d2af66
Compare
|
Internal regression succeeded 🍏: Build ID #241 |
Support conversion of OCI models in the LangGraph adapter, depends on the langchain-oci package. Both conversion directions are supported (Agent Spec -> LangGraph and LangGraph -> Agent Spec). Tests are skipped if the OCI environment variables are not set up.
This PR cannot be merged until CVEs in one of the transitive dependencies are resolved (
cryptography<46.0.0dependency of theocipackage)