[scg] Возможность изменения типа группы элементов

[MaxGavr]

Изменения:

• полностью выполнены требования [scg] Добавить возможность одновременного изменения типа нескольких элементов #423, за исключением:
  • действие изменения типа неактивно и не может быть осуществлено пользователем, если условия не выполнены (выделены не только узлы/пары);
• в диалоге выбора типа добавлена нумерация для упрощения использования сочетаний клавиш.

Close #423.

[deniskoronchik]

for (size_t i = 1; i < objectsList.size(); ++i)
{
    SCgObject const * obj = objectList[i];
    Q_ASSERT(obj); // we should not have nullptr in a list
    if (obj->type() != objectList[0]->type())
        return false;
}

[deniskoronchik]

Remove this assert

[deniskoronchik]

Don't use foreach
use C++11 instead

for (QGraphicsItem* item : itemList)

[deniskoronchik]

Also there we doesn't change item, so it should be QGraphicsItem const * item

[MaxGavr]

Quote from Qt Docs:

An alternative to Qt's foreach loop is the range-based for that is part of C++ 11 and newer. However, keep in mind that the range-based for might force a Qt container to detach, whereas foreach would not. But using foreach always copies the container, which is usually not cheap for STL containers. If in doubt, prefer foreach for Qt containers, and range based for for STL ones.

Detaching a container causes its deep copy. Therefore, foreach is preferable for Qt containers, that are used throughout the project (along with foreach).
Speaking about c++11, it is not yet included to the project. This should be done shortly.

[deniskoronchik]

Add support of C++ 11 and use for (auto it : container)

[deniskoronchik]

rewrite

SCgBaseCommand* SCgScene::deleteSelObjectsCommand(SCgBaseCommand* parentCmd, bool addToStack)

using this function inside

[deniskoronchik]

for (SCgObject* object : objList)

[deniskoronchik]

Strange logic. There should be exception error in this case or Q_ASSERT(parentLayout). I mean remove else return; and replace with check

[deniskoronchik]

return static_cast<SCgScene*>(scene());

[deniskoronchik]

bool canChangeTypesOfSelection(const SCgObject::SCgObjectList & objectList)

[deniskoronchik]

SCgObject::SCgObjectList const objectList = getSCgScene()->getSelectedObjects();
Q_ASSERT(canChangeTypes(objectList));

[deniskoronchik]

Replace to one command:

changeType(objectList, typeDialog.getChosenType());

Doesn't need to process one item separately.

[MaxGavr]

I agree, that functions interface should be reduced to just

SCgScene::changeObjectTypeCommand(const SCgObject::SCgObjectList& objectList, ...)

But inside it, single-object case should be separated, as it is handled differently (without creating parent QUndoCommand) and is widely used by a user.

[deniskoronchik]

That not a problem, you should think, that change type of one element - is a command to change type of N elements, where N == 1.
Main goal to make code more suitable for support. This is not critical code for a memory and performance. So minimize number of code there

[deniskoronchik]

Remove this function

[deniskoronchik]

Remove this function