feat(warcraft): Refactor plugin to use new packages #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor to use opencode-notification package (PR2) - Refactor to use opencode-config package (PR3) - Update notification.ts and notification-core.ts to use shared utilities - Refactor config/loader.ts and config/package.ts to use opencode-config - Update package.json with new dependencies - Update project.json with new targets - Update test utilities and schema validator - Final integration PR demonstrating new packages working together This refactor demonstrates the new opencode-notification and opencode-config packages working in production by migrating the warcraft plugin to use them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors warcraft plugin to use new opencode-notification and opencode-config packages instead of internal implementations.
Changes
Refactor to use opencode-notification package (PR feat(notification): Add opencode-notification utility package #22):
Refactor to use opencode-config package (PR feat(config): Add opencode-config utility package #23):
Update build configuration:
Dependencies
Blocks
Testing
bunx nx test opencode-warcraft-notifications-pluginbunx nx type-check opencode-warcraft-notifications-pluginIntegration Demonstration
This PR demonstrates the new
opencode-notificationandopencode-configpackages working in production by migrating the warcraft plugin to use them instead of internal implementations.