PMM-14624: Fix theme inheritance between users #4830
+108
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove localStorage theme persistence and sync theme from Grafana API on login to prevent new users from inheriting previous user's theme preferences.
dmitri-saricev-3pillargloball
requested review from
YashSartanpara1 and
matejkubinec
dmitri-saricev-3pillargloball
requested a review
from a team
as a code owner
ui/apps/pmm/src/api/user.ts
Outdated
| }; | ||
|
|
||
| export const getUserPreferences = async () => { | ||
| const res = await grafanaApi.get<UpdatePreferencesBody>('/user/preferences'); |
Contributor
There was a problem hiding this comment.
The type UpdatePreferencesBody isn't probably correct (if it's the same payload you can just export it like so:
export type GetPreferencesResponse = UpdatePreferencesBody;
Contributor
There was a problem hiding this comment.
Suggested change
| const res = await grafanaApi.get<UpdatePreferencesBody>('/user/preferences'); | |
| const res = await grafanaApi.get<GetPreferencesResponse>('/user/preferences'); |
- Move GetPreferenceResponse type to user.types.ts - Update useUser.ts to use GetPreferenceResponse type - Rename ThemedyProvider to ThemeSyncProvider
matejkubinec
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove localStorage theme persistence and sync theme from Grafana API on login to prevent new users from inheriting previous user's theme preferences.
https://perconadev.atlassian.net/browse/PMM-14624
result:
Screen.Recording.2025-12-10.at.17.02.51.mov
Link to the Feature Build:
Percona-Lab/pmm-submodules#4149
https://pmm.cd.percona.com/blue/organizations/jenkins/pmm3-submodules/detail/pmm3-submodules/2057/pipeline/
If this PR adds, removes or alters one or more API endpoints, please review and add or update the relevant API documentation as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: