Skip to content

Conversation

@JiriCtvrtka
Copy link
Contributor

@JiriCtvrtka JiriCtvrtka commented Dec 16, 2025

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 50.57471% with 86 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.00%. Comparing base (ad6cac4) to head (db10f7e).
⚠️ Report is 1 commits behind head on v3.

Files with missing lines Patch % Lines
managed/utils/interceptors/go-grpc-prometheus.go 50.87% 78 Missing and 6 partials ⚠️
managed/cmd/pmm-managed/main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #4848      +/-   ##
==========================================
+ Coverage   45.95%   46.00%   +0.05%     
==========================================
  Files         365      366       +1     
  Lines       38223    38394     +171     
==========================================
+ Hits        17564    17665     +101     
- Misses      18969    19034      +65     
- Partials     1690     1695       +5     
Flag Coverage Δ
admin 17.82% <ø> (ø)
agent 53.54% <ø> (+0.16%) ⬆️
managed 46.67% <50.57%> (+0.02%) ⬆️
vmproxy 72.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@percona percona deleted a comment from percona-robot Dec 23, 2025
@percona percona deleted a comment from percona-robot Dec 23, 2025
@percona percona deleted a comment from percona-robot Dec 23, 2025
@percona percona deleted a comment from percona-robot Dec 23, 2025
@percona percona deleted a comment from percona-robot Dec 23, 2025
@percona percona deleted a comment from percona-robot Dec 23, 2025
go.mod Outdated
Comment on lines 8 to 12
replace github.com/go-openapi/spec => github.com/JiriCtvrtka/spec v0.0.0-20251222101011-485c12f10ee3

replace github.com/go-openapi/spec => github.com/Percona-Lab/spec v0.21.0-percona
replace github.com/alecthomas/kingpin/v2 => github.com/Percona-Lab/kingpin/v2 v2.0.0-20251219125400-95ff74a47c0a

replace github.com/alecthomas/kingpin/v2 => github.com/Percona-Lab/kingpin/v2 v2.4.0-percona

replace golang.org/x/crypto => github.com/percona-lab/crypto v0.0.0-20231108144114-756dfb24eaf2
replace golang.org/x/crypto => github.com/percona-lab/crypto v0.0.0-20251219125031-82d8ba2cda22
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merge of PR all will be replaced with proper commit (after those are merged).

go.mod Outdated
// go get -v github.com/percona/saas@latest

replace github.com/grpc-ecosystem/go-grpc-prometheus => github.com/Percona-Lab/go-grpc-prometheus v0.0.0-20230116133345-3487748d4592
replace github.com/go-openapi/spec => github.com/JiriCtvrtka/spec v0.0.0-20251222101011-485c12f10ee3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont have permissions to this repo. This is only for now. Once finished it will be replaced with proper commit in Percona spec repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we have a new version now.

@@ -0,0 +1,389 @@
// Copyright (C) 2023 Percona LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is copied - should we keep their license?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains mainly code from Percona fork itself. It is bare minimum to make PMM work with upstream one. So I think it this case it is fine.

@JiriCtvrtka JiriCtvrtka marked this pull request as ready for review December 29, 2025 12:15
@JiriCtvrtka JiriCtvrtka requested a review from a team December 29, 2025 12:15
@JiriCtvrtka JiriCtvrtka requested a review from a team as a code owner December 29, 2025 12:15
@JiriCtvrtka JiriCtvrtka requested review from BupycHuk and maxkondr and removed request for a team December 29, 2025 12:15
@JiriCtvrtka JiriCtvrtka merged commit 9f748ec into v3 Jan 7, 2026
29 checks passed
@JiriCtvrtka JiriCtvrtka deleted the PMM-14577-CVEs-fix branch January 7, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants