Skip to content

Conversation

@ademidoff
Copy link
Member

@ademidoff ademidoff commented Dec 24, 2025

PMM-14643

Link to the Feature Build: SUBMODULES-4173

If this PR adds, removes or alters one or more API endpoints, please review and add or update the relevant API documentation as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

impimp and others added 4 commits December 17, 2025 18:23
This commit adds methods for reading private key file as well as
Encrypt/Decrypt methods. Config file is encrypted with AES key stored on the beginning of the file, and that key is encrypted with RSA key given by the user.
This commit injects encryption and decryption configuration file in
`readFromFile` and `SaveToFile` methods. Also, it modifies tests previously existing tests, so that in those encryption is not used.
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.02%. Comparing base (4088a94) to head (f3576a2).
⚠️ Report is 1 commits behind head on v3.

Files with missing lines Patch % Lines
agent/config/encryption.go 56.25% 14 Missing and 14 partials ⚠️
agent/config/config.go 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #4870      +/-   ##
==========================================
+ Coverage   45.98%   46.02%   +0.03%     
==========================================
  Files         365      366       +1     
  Lines       38223    38301      +78     
==========================================
+ Hits        17578    17628      +50     
- Misses      18956    18969      +13     
- Partials     1689     1704      +15     
Flag Coverage Δ
admin 17.82% <ø> (ø)
agent 53.61% <62.50%> (+0.10%) ⬆️
managed 46.65% <ø> (-0.01%) ⬇️
vmproxy 72.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ademidoff ademidoff marked this pull request as ready for review December 27, 2025 00:22
@ademidoff ademidoff requested a review from a team December 27, 2025 00:22
@ademidoff ademidoff requested a review from a team as a code owner December 27, 2025 00:22
@ademidoff ademidoff requested review from BupycHuk, idoqo and maxkondr and removed request for a team December 27, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants