Skip to content

[pfsense_interface] Support diff mode #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opoplawski merged 1 commit into from
Jan 22, 2026
Merged

[pfsense_interface] Support diff mode #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/228_interface_diff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- pfsense_interface - support ``--diff`` (https://github.com/pfsensible/core/pull/228).
7 changes: 3 additions & 4 deletions plugins/module_utils/interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,15 +217,13 @@ def _validate_params(self):
def _copy_and_add_target(self):
""" create the XML target_elt """
self.pfsense.copy_dict_to_element(self.obj, self.target_elt)
self.diff['after'] = self.obj
self.setup_interface_cmds += "interface_configure('{0}', true);\n".format(self.target_elt.tag)
self.result['ifname'] = self.target_elt.tag

def _copy_and_update_target(self):
""" update the XML target_elt """
before = self.pfsense.element_to_dict(self.target_elt)
changed = self.pfsense.copy_dict_to_element(self.obj, self.target_elt)
if self._remove_deleted_params():
changed = True
(before, changed) = super(PFSenseInterfaceModule, self)._copy_and_update_target()

if changed:
if self.params['enable']:
Expand Down Expand Up @@ -326,6 +324,7 @@ def _get_params_to_remove():

def _pre_remove_target_elt(self):
""" processing before removing elt """
super(PFSenseInterfaceModule, self)._pre_remove_target_elt()
self.obj['if'] = self.target_elt.find('if').text

ifname = self.target_elt.tag
Expand Down