Improve Docker test validation to catch silent SQL #299
+38
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Spockbench errors would fail silently because: 1. run-tests.sh had 'set -euo pipefail' commented out 2. check-outputs.sh only validated container exit codes 3. PostgreSQL logs were never checked for errors This meant the old log_old_value syntax could have been failing silently without triggering test failures in GitHub Actions. Changes: 1. run-tests.sh: - Uncommented 'set -euo pipefail' to fail fast on errors - Now SQL errors will immediately terminate the script 2. check-outputs.sh: - Added validation that containers actually exist - Added PostgreSQL log error checking - Scans pg logs for ERROR entries (excluding benign "relation does not exist") - Shows container logs on failure for debugging - Provides clear pass/fail feedback This ensures that: - SQL syntax errors are caught immediately - Database errors don't go unnoticed - Test failures are visible in CI/CD - Debugging is easier with automatic log output Now Spockbench will fail until the following commits fix detected issues.
danolivo
force-pushed
the
spoc-354
branch
4 times, most recently
from
5c3bbc1 to
eb2fd79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that spockbench doesn't check anything now. Try to improve it.