Improve the conversion of arrays to strings #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
reviewed
Dec 13, 2025
src/Types/AbstractList.php
Outdated
Comment on lines
91
to
92
| !preg_match('/[^\w\\\\]/', (string) $this->valueType) || | ||
| substr((string) $this->valueType, -2, 2) === '[]' |
Member
There was a problem hiding this comment.
do we want to match on [] in the middle of a type?
Contributor
Author
There was a problem hiding this comment.
I didn't quite understand the question
Contributor
Author
There was a problem hiding this comment.
I added this to handle multidimensional arrays correctly. For example, string[][]
Contributor
Author
|
I suggest moving all this logic to |
Contributor
Author
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.