Fix broken contrib discussion search #417
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416
This is not possible for me test in any capacity locally. So I had to really on help from Claude on this one.
Summary of Fixes
get_document_url()method (lines 526-575) - Defense in depth$paramsis a valid non-empty arrayget_posts()method (lines 667-704) - Fixes support topic error$url_paramsis a valid non-empty arraypost_urlfield already containscontrib_typeandcontribfrom the databaseget_contribs()method (lines 714-748) - Prevents contrib route errorscontrib_type_obj exists before accessing its propertiesget_faqs()method (lines 758-794) - Fixes FAQ item errorcontrib_type_objexists before accessing its propertiesThese fixes work in layers:
get_*()methods filter out any documents with invalid or missing parametersget_document_url()method validates all required parameters are present before attempting to generate a route