Skip to content

fix(viewer): Unneeded manual internal link; Fix target is in LaTeX #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yhx-12243 wants to merge 2 commits into
base: main
Choose a base branch
from
+0 −9
Open

fix(viewer): Unneeded manual internal link; Fix target is in LaTeX #215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f10cb9f
fix(viewer): Unneeded manual internal link; Fix target is in LaTeX
yhx-12243 Oct 24, 2038
4cf397b
Rerun tests
yhx-12243 Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/viewer/src/components/Shared/Typeset.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@
}
}

/**
* We're adding "real" <a/> tags to the DOM, even for parsed internal
* links, but we really want to use the router to navigate. So we manually
* bind click handlers to trigger navigation.
*/
for (const link of container.getElementsByClassName('internal-link')) {
/**
* Unloading a DOM node should remove any bound listeners, but it's
Expand All @@ -48,10 +43,6 @@
})

link.setAttribute('_wired', 'true')
link.addEventListener('click', e => {
e.preventDefault()
goto((e.target as HTMLAnchorElement).href)
})
}
}

Expand Down
Loading