tikv-configuration-file: update flow-control override behavior for v8.5.5 #22296
Conversation
qiancai
added
needs-cherry-pick-release-8.5
ti-chi-bot
bot
added
the
size/XS
Summary of ChangesHello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request intends to update the documentation for TiKV's flow control configuration parameters. It clarifies a significant behavior change introduced in TiDB v8.5.5, where certain flow control settings will now conditionally override RocksDB's corresponding settings only if the flow control value is smaller, thereby preserving RocksDB's compaction acceleration mechanisms. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request's description indicates an update to the TiKV configuration documentation for flow-control behavior in v8.5.5. However, the submitted changes only add a temporary file, temp.md, which does not seem related to the described documentation update. Please verify that the correct files have been committed and pushed. I have added a minor comment on the new file regarding a missing newline.
I am having trouble creating individual review comments. Click here to see my feedback.
temp.md (1)
This file appears to be a temporary test file that might have been added unintentionally. If so, it should be removed. If this file is intended to be part of the pull request, please note that it is missing a final newline character. It is a common convention to end files with a newline to avoid issues with some tools and file concatenations.
This is a test file.
Synced from: pingcap/docs-cn#21244 Target PR: pingcap#22296 AI Provider: gemini Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ti-chi-bot
bot
added
size/S
|
@hhwyt: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[LGTM Timeline notifier]Timeline:
|
Co-authored-by: Aolin <aolinz@outlook.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qiancai
added
area/engine
|
@qiancai: You cannot manually add or delete the cherry pick approval state labels, only I and the tursted members have permission to do so. You can approve it in internal platform. DetailsIn response to removing label named approved. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Synced from: pingcap/docs-cn#21244 Target PR: pingcap#22296 AI Provider: gemini Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
In response to a cherrypick label: new pull request created to branch |
4 participants
What is changed, added or deleted? (Required)
ref tikv/tikv#18994
Update documentation for
storage.flow-control.l0-files-thresholdandstorage.flow-control.soft-pending-compaction-bytes-limitto reflect the behavior change introduced in TiKV PR #18994.Also update the corresponding RocksDB config items (
level0-slowdown-writes-trigger,soft-pending-compaction-bytes-limit) with the same version-specific behavior notes.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?