Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #22268

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3. labels Jan 13, 2026
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 13, 2026
14 tasks
@gemini-code-assist
Copy link

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the documentation for the ALTER TABLE ... MODIFY COLUMN statement in TiDB. The updates provide a clearer understanding of how column type changes are handled, particularly regarding Reorg-Data operations. It also introduces significant new information about recent performance optimizations in newer TiDB versions that can reduce the overhead of certain column modifications by avoiding full table rebuilds under specific conditions.

Highlights

  • Enhanced MODIFY COLUMN Documentation: The documentation for ALTER TABLE ... MODIFY COLUMN has been significantly expanded to provide a more detailed explanation of Reorg-Data behavior during column type changes.
  • Performance Optimizations for MODIFY COLUMN: New information has been added regarding performance optimizations introduced in TiDB v8.5.5 and v9.0.0. These optimizations allow certain column modifications to rebuild only affected indexes instead of the entire table, under specific conditions, thereby improving execution efficiency.
  • Conditions for Optimizations: The documentation now clarifies the conditions required for these MODIFY COLUMN optimizations, including the use of a strict SQL mode, the absence of TiFlash replicas, and no risk of data truncation.
  • Specific Conversion Notes: A new note has been added to address the behavior of VARCHAR to CHAR conversions, specifically highlighting the impact of trailing spaces on Reorg-Data operations.
  • Wording and Clarity Improvements: Minor textual adjustments have been made for consistency, such as changing section headings from 'Meta-Only Change' to 'Meta-only change', and clarifying the DDL statement wait time when Metadata lock is disabled.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@qiancai qiancai changed the title refine modify column (#22268) 8.5.5: refine modify column (#22268) Jan 13, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refines the documentation for MODIFY COLUMN, providing more details about Reorg-Data operations and related optimizations. The changes are well-written and improve the clarity of the document. I've provided a few suggestions to further enhance readability and consistency, mainly around the usage of the term 'Reorg-Data'.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiancai qiancai changed the base branch from release-8.5 to feature/preview-v8.5.5 January 13, 2026 10:10
@qiancai qiancai changed the title 8.5.5: refine modify column (#22268) v8.5.5: refine modify column (#22268) Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants